This repository has been archived by the owner on Jan 22, 2021. It is now read-only.
Template dirs in setup.py #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… being Python modules, to setup
|
Yes please pull |
|
@alex: I've sent another pull request similar to yours. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I modified setup.py to include the template dirs for each app. Before this, installing via pip would not include them since they weren't Python packages. Data files have to be explicitly included in setup.py. The way I did it is a little brittle, but should work with any Django project I've personally seen - maybe you know a better way, but it seems to work fine for basic-apps at least.
Thanks for your hard work on this!
Alex