Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle duplicate icon entries in include config #245

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

stramel
Copy link
Collaborator

@stramel stramel commented Oct 22, 2024

Fixes #237

@stramel stramel added the bug Something isn't working label Oct 22, 2024
@stramel stramel self-assigned this Oct 22, 2024
Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 3e4f432

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 3:37am
astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 3:37am

Copy link
Owner

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natemoo-re natemoo-re merged commit ff3a66a into main Nov 5, 2024
6 checks passed
@natemoo-re natemoo-re deleted the fix-duplicate-icon-specified branch November 5, 2024 03:38
@github-actions github-actions bot mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when duplicate icon names are included in config
2 participants