fix(Icon): switch to non-deprecated href attribute (#243)

* fix(Icon): switch to non-deprecated href attribute * docs(components): update usages in components guide * docs: add changeset * Update .changeset/young-dots-tell.md --------- Co-authored-by: Nate Moore <[email protected]>
natemoo-re · Nov 5, 2024 · a8c0a6c · a8c0a6c
1 parent ff3a66a
commit a8c0a6c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/young-dots-tell.md b/.changeset/young-dots-tell.md
@@ -0,0 +1,6 @@
+---
+"astro-icon": patch
+"www": patch
+---
+
+Replaces deprecated `xlink:href` attribute with standard `href` attribute
diff --git a/packages/core/components/Icon.astro b/packages/core/components/Icon.astro
@@ -130,7 +130,7 @@ if (includeSymbol) {
     ) : (
       <Fragment>
         {includeSymbol && <symbol id={id} viewBox={viewBox} set:html={normalizedBody} />}
-        <use xlink:href={`#${id}`} />
+        <use href={`#${id}`} />
       </Fragment>
     )
   }

diff --git a/packages/www/src/content/docs/guides/components.mdx b/packages/www/src/content/docs/guides/components.mdx
@@ -56,13 +56,13 @@ import { Icon } from 'astro-icon/components'
 <!-- First usage generates the following HTML -->
 <svg data-icon="logo">
 	<symbol id="ai:uniqueid"><!-- contents of /src/icons/logo.svg --></symbol>
-	<use xlink:href="#ai:uniqueid"></use>
+	<use href="#ai:uniqueid"></use>
 </svg>
 
 <Icon name="logo" />
 <!-- Additional usage generates the following HTML -->
 <svg data-icon="logo">
-	<use xlink:href="#ai:uniqueid"></use>
+	<use href="#ai:uniqueid"></use>
 </svg>
 ```