fix type error on import.meta.env

natemoo-re · Sep 26, 2024 · 05d358c · 05d358c
1 parent 57a42a4
commit 05d358c
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 6 deletions.
diff --git a/demo/package.json b/demo/package.json
@@ -11,6 +11,6 @@
   "dependencies": {},
   "devDependencies": {
     "astro": "^4.15.9",
-    "astro-icon": "../packages/core"
+    "astro-icon": "workspace:^"
   }
 }
diff --git a/packages/core/src/utils/icon.ts b/packages/core/src/utils/icon.ts
@@ -38,7 +38,6 @@ async function fetchCollection(collection: string, { cache }: { cache: FileCache
 
   if (!collectionData) {
     const err = new AstroIconError(`Unable to locate the icon collection "${collection}"`);
-    // @ts-expect-error -- TODO: figure out why this is throwing an error
     if (import.meta.env.DEV) {
       err.hint = `The "${collection}" icon collection does not exist.\n\nIs this a typo?`;
     }
@@ -59,7 +58,6 @@ export async function getIconData(
   const { icons } = collectionData;
   if (icons[name] === undefined) {
     const err = new AstroIconError(`Unable to locate the icon "${collection}:${name}"`);
-    // @ts-expect-error -- TODO: figure out why this is throwing an error
     if (import.meta.env.DEV) {
       err.hint = `The "${collection}" icon collection does not include an icon named "${name}".\n\nIs this a typo?`;
     }

diff --git a/packages/core/tsconfig.json b/packages/core/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "extends": "../../tsconfig.base.json",
-  "include": ["src"],
+  "include": ["src", "typings"],
   "compilerOptions": {
     "allowJs": true,
     "module": "NodeNext",

diff --git a/packages/core/typings/virtual.d.ts b/packages/core/typings/virtual.d.ts
@@ -1,4 +1,4 @@
-/// <reference types="astro/jsx-runtime" />
+/// <reference types="astro/client" />
 
 declare module "astro:icons/*" {
   type Props = {

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml