Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out ADS entries for duplicate bibcodes #2655

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

lpsinger
Copy link
Member

Fixes #2639.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 6.21%. Comparing base (7321140) to head (3a1644e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
app/scheduled/ads/index.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2655      +/-   ##
========================================
- Coverage   6.22%   6.21%   -0.01%     
========================================
  Files        167     167              
  Lines       4225    4231       +6     
  Branches     467     467              
========================================
  Hits         263     263              
- Misses      3960    3966       +6     
  Partials       2       2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dakota002 dakota002 merged commit ab67535 into nasa-gcn:main Oct 30, 2024
12 checks passed
@lpsinger lpsinger deleted the filter-duplicate-bibcodes branch October 31, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated circulars are being distributed in batches
2 participants