Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link for Einstein Probe example alert JSON #2633

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

jak574
Copy link
Contributor

@jak574 jak574 commented Oct 18, 2024

Description

The link to an example JSON alert for Einstein probe on this page: https://gcn.nasa.gov/missions/einstein-probe leads to a 404 due to an error in the linked filename.

Testing

Tested in local development environment.

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@lpsinger lpsinger merged commit e4bed74 into nasa-gcn:main Oct 18, 2024
10 checks passed
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.22%. Comparing base (226d170) to head (086f417).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2633   +/-   ##
=====================================
  Coverage   6.22%   6.22%           
=====================================
  Files        167     167           
  Lines       4222    4222           
  Branches     466     466           
=====================================
  Hits         263     263           
  Misses      3957    3957           
  Partials       2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants