Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Synonym link to NavBar for moderators #2619

Closed
wants to merge 2 commits into from

Conversation

Courey
Copy link
Contributor

@Courey Courey commented Oct 10, 2024

Description

Adding moderator gated link to Synonyms moderation route.

With the link not visible as a non-logged in user:
Screenshot 2024-10-10 at 5 06 57 PM

With the link visible:
Screenshot 2024-10-10 at 5 06 44 PM

With the link not visible as a logged in user:
Screenshot 2024-10-10 at 5 10 19 PM

Mobile view:
Screenshot 2024-10-10 at 5 13 54 PM
Screenshot 2024-10-10 at 5 13 47 PM

and because I know you'll ask about it, the reason I added style={{ width: 'max-content' }} to the Title is because without it, the additional characters in the PrimaryNav cause the "General Coordinates Network" to all stack on top of each other which makes the header very noticeably taller than normal. Here is an image without that style added:
Screenshot 2024-10-10 at 4 06 11 PM

I can add "Syno" without anything changing at all, but if you add the rest of the word things start to change slightly to fit all the text in the nav bar.

Related Issue(s)

Resolves #2618

Testing

Manual testing both as a logged in moderator and a logged out user. This should be tested on dev with a logged out user, a logged in non-moderator user, and a logged in moderator.

@Courey Courey changed the title Courey/add synonym link to nav Add Synonym link to NavBar for moderators Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 6.08%. Comparing base (0fa60e5) to head (0baeb37).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
app/root/header/Header.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2619      +/-   ##
========================================
- Coverage   6.08%   6.08%   -0.01%     
========================================
  Files        164     164              
  Lines       4073    4074       +1     
  Branches     450     450              
========================================
  Hits         248     248              
- Misses      3823    3824       +1     
  Partials       2       2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this should be a top-level nav button. Where else could we put the link?

@Courey
Copy link
Contributor Author

Courey commented Oct 16, 2024

This version puts it on the circulars archive index page as a button next to the change request button #2630
closing in favor of that version.

@Courey Courey closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Synonyms Moderation Button to Circular index page
2 participants