Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the change request form to populate with previously requested changes if they exist #2585

Merged
merged 8 commits into from
Sep 18, 2024
Merged

Updates the change request form to populate with previously requested changes if they exist #2585

merged 8 commits into from
Sep 18, 2024

Conversation

dakota002
Copy link
Contributor

Currently requesting sequential changes for a circular will replace whatever request already exists with the new changes.

This pulls that info in now so if a user is to say submit a request to update the subject, then come back and later update the body before their request is approved, their request will now have both changes and be tied to the same zendesk ticket

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 6.08%. Comparing base (ce005eb) to head (a822f25).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
app/routes/circulars._archive._index/route.tsx 0.00% 6 Missing ⚠️
app/lib/zendesk.server.ts 0.00% 5 Missing ⚠️
app/routes/circulars.correction.$circularId.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            main   #2585      +/-   ##
========================================
- Coverage   6.10%   6.08%   -0.02%     
========================================
  Files        164     164              
  Lines       4065    4077      +12     
  Branches     444     450       +6     
========================================
  Hits         248     248              
- Misses      3815    3827      +12     
  Partials       2       2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lpsinger
lpsinger requested changes Sep 17, 2024
View reviewed changes
app/routes/circulars._archive._index/route.tsx Outdated Show resolved Hide resolved
app/routes/circulars._archive._index/route.tsx Outdated Show resolved Hide resolved
lpsinger
lpsinger requested changes Sep 18, 2024
View reviewed changes
app/routes/circulars.correction.$circularId.tsx Outdated Show resolved Hide resolved
app/routes/circulars._archive._index/route.tsx Outdated Show resolved Hide resolved
@dakota002
Copy link
Contributor Author

Sure, I can update it in the next commit

@dakota002
Copy link
Contributor Author

@lpsinger Also, do you think it makes more sense that this method should then just return the Id?

@lpsinger
Copy link
Member

@lpsinger Also, do you think it makes more sense that this method should then just return the Id?

Good idea.

lpsinger
lpsinger requested changes Sep 18, 2024
View reviewed changes
app/lib/zendesk.server.ts Outdated Show resolved Hide resolved
app/routes/circulars._archive._index/route.tsx Outdated Show resolved Hide resolved
@lpsinger lpsinger merged commit 54ea8ce into nasa-gcn:main Sep 18, 2024
12 checks passed
@dakota002 dakota002 deleted the ChangeRequestUpdate branch September 18, 2024 20:05
Vidushi-GitHub pushed a commit to Vidushi-GitHub/gcn.nasa.gov that referenced this pull request Oct 13, 2024
@dakota002 @lpsinger
Updates the change request form to populate with previously requested…
8863541 
… changes if they exist (nasa-gcn#2585)

* Updates the change request form to populate with previously requested changes if they exist

* throw all but the 404, types on zendeskticketId

* Apply type narrowing

* Update function to throw error and just return Id

* Update app/lib/zendesk.server.ts

Co-authored-by: Leo Singer <[email protected]>

* Update app/routes/circulars._archive._index/route.tsx

Co-authored-by: Leo Singer <[email protected]>

* Add final check for undefined

* Prettier on zendesk server

---------

Co-authored-by: Leo Singer <[email protected]>
Vidushi-GitHub pushed a commit to Vidushi-GitHub/gcn.nasa.gov that referenced this pull request Oct 13, 2024
@dakota002 @lpsinger
Updates the change request form to populate with previously requested…
4c63ea4 
… changes if they exist (nasa-gcn#2585)

* Updates the change request form to populate with previously requested changes if they exist

* throw all but the 404, types on zendeskticketId

* Apply type narrowing

* Update function to throw error and just return Id

* Update app/lib/zendesk.server.ts

Co-authored-by: Leo Singer <[email protected]>

* Update app/routes/circulars._archive._index/route.tsx

Co-authored-by: Leo Singer <[email protected]>

* Add final check for undefined

* Prettier on zendesk server

---------

Co-authored-by: Leo Singer <[email protected]>
Vidushi-GitHub pushed a commit to Vidushi-GitHub/gcn.nasa.gov that referenced this pull request Nov 6, 2024
@dependabot @lpsinger
Bump @babel/preset-env from 7.25.3 to 7.25.4
b2a6f16 
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.25.3 to 7.25.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.25.4/packages/babel-preset-env)

---
updated-dependencies:
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Puts test message behind a captcha (nasa-gcn#2547)

Prefer deduplication when installing packages

This decreases the chances of obscure TypeScript errors due to
having multiple versions of the same package in the tree.

Fix broken Circulars hyperlinks by pinning Remix version

Pin Remix version to 2.10.3 to fix broken Circulars cross-reference
hyperlinks.

Fixes nasa-gcn#2563.

Add direct dependency on esbuild

We had an inderect dependency on esbuild because Remix depends on
it, but we should have a direct dev dependency as well because our
own build system calls esbuild itself.

Always send new versions of GCN Circulars over Kafka

See nasa-gcn#2562.

Updates the change request functions to automatically close the corresponding zendesk ticket (nasa-gcn#2546)

Bump lint-staged from 15.2.8 to 15.2.10

Bumps [lint-staged](https://github.com/lint-staged/lint-staged) from 15.2.8 to 15.2.10.
- [Release notes](https://github.com/lint-staged/lint-staged/releases)
- [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md)
- [Commits](lint-staged/lint-staged@v15.2.8...v15.2.10)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Adds option to redistribute email for circulars (nasa-gcn#2569)

Resolves nasa-gcn#2562.

Bump husky from 9.1.4 to 9.1.6

Bumps [husky](https://github.com/typicode/husky) from 9.1.4 to 9.1.6.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v9.1.4...v9.1.6)

---
updated-dependencies:
- dependency-name: husky
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Bump @types/node from 22.5.0 to 22.5.5

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.0 to 22.5.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Bump vite

Bumps  and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). These dependencies needed to be updated together.

Updates `vite` from 5.4.3 to 5.4.6
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite)

Updates `vite` from 4.5.3 to 5.4.6
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: indirect
- dependency-name: vite
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

clarify conditions for when most_probable_direction is present

Bump serve-static and express

Bumps [serve-static](https://github.com/expressjs/serve-static) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `serve-static` from 1.15.0 to 1.16.2
- [Release notes](https://github.com/expressjs/serve-static/releases)
- [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md)
- [Commits](expressjs/serve-static@v1.15.0...v1.16.2)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: serve-static
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Set IceCube notice field names in a code font

Updates the change request form to populate with previously requested changes if they exist (nasa-gcn#2585)

* Updates the change request form to populate with previously requested changes if they exist

* throw all but the 404, types on zendeskticketId

* Apply type narrowing

* Update function to throw error and just return Id

* Update app/lib/zendesk.server.ts

Co-authored-by: Leo Singer <[email protected]>

* Update app/routes/circulars._archive._index/route.tsx

Co-authored-by: Leo Singer <[email protected]>

* Add final check for undefined

* Prettier on zendesk server

---------

Co-authored-by: Leo Singer <[email protected]>

Bump rollup

Bumps  and [rollup](https://github.com/rollup/rollup). These dependencies needed to be updated together.

Updates `rollup` from 4.21.2 to 4.22.4
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.21.2...v4.22.4)

Updates `rollup` from 3.29.4 to 4.22.4
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.21.2...v4.22.4)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
- dependency-name: rollup
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Bump @testing-library/react from 16.0.0 to 16.0.1

Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 16.0.0 to 16.0.1.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v16.0.0...v16.0.1)

---
updated-dependencies:
- dependency-name: "@testing-library/react"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Moves the definition of the send function to resolve issues with kafka related imports in the remix build (nasa-gcn#2590)

Fixes nasa-gcn#2588.

correct typo

Bump typescript from 5.5.4 to 5.6.2

Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.5.4 to 5.6.2.
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.5.4...v5.6.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Bump eslint from 8.56.0 to 8.57.1

Bumps [eslint](https://github.com/eslint/eslint) from 8.56.0 to 8.57.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.56.0...v8.57.1)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

update burstcube status

remove unused import

Bump @types/color-convert from 2.0.1 to 2.0.4

Bumps [@types/color-convert](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/color-convert) from 2.0.1 to 2.0.4.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/color-convert)

---
updated-dependencies:
- dependency-name: "@types/color-convert"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Circulars - Lucene search documentation (nasa-gcn#2502)

Add lvk notice unique ID documentation

Bump @playwright/test from 1.46.1 to 1.48.0

Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.46.1 to 1.48.0.
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.46.1...v1.48.0)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

draft news items

fixed news anchor

adds synonyms moderation front end (nasa-gcn#2538)

Resolves nasa-gcn#2116.

adding synonym moderation link to circulars index page

Adds fermi gbm to json quickstart behind feature flag

Adds other alerts from feedback

Updates schema docs to clarify unevaluatedProperties use

Revise the docs for schema

new producer template

Bump @xmldom/xmldom from 0.8.10 to 0.9.4

Bumps [@xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.8.10 to 0.9.4.
- [Release notes](https://github.com/xmldom/xmldom/releases)
- [Changelog](https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md)
- [Commits](xmldom/xmldom@0.8.10...0.9.4)

---
updated-dependencies:
- dependency-name: "@xmldom/xmldom"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Fix link for EP example alert JSON

SVOM Mission Page

Update app/routes/missions.svom/route.mdx

Co-authored-by: Leo Singer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpsinger lpsinger lpsinger approved these changes

@Courey Courey Awaiting requested review from Courey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakota002 @lpsinger