Address issue raised on gcn-schema #189 #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2584 +/- ##
=====================================
Coverage 6.10% 6.10%
=====================================
Files 164 164
Lines 4065 4065
Branches 444 444
=====================================
Hits 248 248
Misses 3815 3815
Partials 2 2 ☔ View full report in Codecov by Sentry. |
lpsinger
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
@jessiethw, this looks good to me. Can you recommend someone as a reviewer? Would @blaufuss be a good choice?
thanks, and yes that would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the case for when the "most_probable_direction" key is included in the lvk_nu_track_search follow up GCN, raised in nasa-gcn/gcn-schema#189
The most probable direction is included when the p-value for the generic transient search is <10%. This PR updates the IceCube docs to reflect this case.