Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds synonyms moderation front end #2538

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

Courey
Copy link
Contributor

@Courey Courey commented Aug 14, 2024

Description

This is the front end for the moderation portion of synonyms (not the circular index grouped by synonyms, but the ability to create, put, delete the synonyms themselves). It is behind both a feature flag and a moderator check. The majority of the code is behind a feature flag and moderation gate, but I did create a component for pagination to reduce redundancy so I could reuse it for this work. In order to do that I had to update the circulars index page as well. That portion is NOT behind a feature flag.

Related Issue(s)

Resolves #2116

Testing

This is the moderation index with pagination. Links for each group are to the detail page
Screenshot 2024-08-13 at 4 34 31 PM

This is the detail page for a synonym group. The button to save is disabled because no additional eventIds have been added. It is enabled when a new eventId is added.
Screenshot 2024-08-14 at 10 04 06 AM

This is the error shown if you enter an eventId that doesn't exist.
Screenshot 2024-08-14 at 2 50 48 PM

This is the create view with no eventIds added.
Screenshot 2024-08-14 at 10 05 12 AM

This is the same view with eventIds added.
Screenshot 2024-08-14 at 10 05 44 AM

This is the error shown when you try to create a synonym group with an invalid eventId
Screenshot 2024-08-14 at 2 37 14 PM

@jracusin
Copy link
Contributor

When you delete synonyms, does it double check you meant to delete them? If not, it would be good to do so.

@Courey
Copy link
Contributor Author

Courey commented Aug 14, 2024

When you delete synonyms, does it double check you meant to delete them? If not, it would be good to do so.

It does not currently, but that is definitely something I can add in!

@Courey
Copy link
Contributor Author

Courey commented Aug 16, 2024

Here are updated images to show the additional request for a modal making sure you want to delete a synonym group.
I also updated the trashcan icon next to each eventId so that it says remove instead of just uses an icon.
Screenshot 2024-08-16 at 11 41 34 AM
Screenshot 2024-08-16 at 11 41 56 AM
Screenshot 2024-08-16 at 11 44 38 AM
Screenshot 2024-08-16 at 11 44 56 AM

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 10.82474% with 173 lines in your changes missing coverage. Please review.

Project coverage is 6.23%. Comparing base (0fa60e5) to head (97ba0e3).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
app/routes/synonyms.new.tsx 0.00% 57 Missing ⚠️
app/routes/synonyms.$synonymId.tsx 0.00% 55 Missing ⚠️
app/routes/synonyms._index.tsx 0.00% 35 Missing ⚠️
app/routes/synonyms/synonyms.server.ts 63.63% 12 Missing ⚠️
...omponents/pagination/PaginationSelectionFooter.tsx 0.00% 8 Missing ⚠️
app/routes/synonyms/route.tsx 0.00% 3 Missing ⚠️
app/routes/circulars._archive._index/route.tsx 0.00% 2 Missing ⚠️
app/components/pagination/Pagination.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2538      +/-   ##
========================================
+ Coverage   6.08%   6.23%   +0.14%     
========================================
  Files        164     167       +3     
  Lines       4073    4219     +146     
  Branches     450     465      +15     
========================================
+ Hits         248     263      +15     
- Misses      3823    3954     +131     
  Partials       2       2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Courey Courey marked this pull request as ready for review August 16, 2024 15:53
app/routes/synonyms._index.tsx Outdated Show resolved Hide resolved
app/routes/synonyms._index.tsx Outdated Show resolved Hide resolved
app/routes/synonyms._index.tsx Outdated Show resolved Hide resolved
app/routes/synonyms.new.tsx Outdated Show resolved Hide resolved
app/routes/synonyms.new.tsx Outdated Show resolved Hide resolved
app/routes/synonyms/route.tsx Outdated Show resolved Hide resolved
app/routes/synonyms/route.tsx Outdated Show resolved Hide resolved
app/routes/synonyms/synonyms.lib.ts Outdated Show resolved Hide resolved
@Courey Courey requested a review from dakota002 August 28, 2024 14:28
Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything in the action functions that checks that the user is authorized.

app/routes/synonyms.new.tsx Show resolved Hide resolved
app/routes/synonyms._index.tsx Show resolved Hide resolved
app/routes/synonyms/route.tsx Outdated Show resolved Hide resolved
app/routes/synonyms.$synonymId.tsx Outdated Show resolved Hide resolved
app/routes/synonyms/synonyms.server.ts Outdated Show resolved Hide resolved
app/routes/synonyms/synonyms.server.ts Outdated Show resolved Hide resolved
@Courey
Copy link
Contributor Author

Courey commented Sep 13, 2024

With nothing on the page yet
Screenshot 2024-09-13 at 1 09 56 PM

when you type 3 or more characters
Screenshot 2024-09-13 at 1 10 33 PM

When you hover over one of the options
Screenshot 2024-09-13 at 1 10 43 PM

@Courey Courey force-pushed the courey/synonyms_index_frontend branch from 3149fdc to 8a67744 Compare September 20, 2024 13:11
Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took me so long to get to. There are some merge conflicts. Would you please rebase from main?

Squashing your existing commits before rebasing might make it easier.

@Courey Courey force-pushed the courey/synonyms_index_frontend branch from 8a67744 to 01a90ab Compare October 9, 2024 14:02
adds validation and error handling

fixes tests

adds modal warning prior to delete

changes removal button to words instead of only icons

code review change requests

removing unused className

formatting

autofill moderator synonym eventId selector

adding create sad path test

removing feature flag check

adding a 3 second debounce
@Courey Courey force-pushed the courey/synonyms_index_frontend branch from 01a90ab to 57134ec Compare October 9, 2024 14:03
@Courey Courey requested a review from lpsinger October 9, 2024 14:19
app/components/pagination/GCNPagination.tsx Outdated Show resolved Hide resolved
app/routes/synonyms.$synonymId.tsx Outdated Show resolved Hide resolved
app/routes/synonyms.$synonymId.tsx Outdated Show resolved Hide resolved
app/routes/synonyms.$synonymId.tsx Outdated Show resolved Hide resolved
app/routes/synonyms._index.tsx Outdated Show resolved Hide resolved
app/routes/synonyms.$synonymId.tsx Outdated Show resolved Hide resolved
@lpsinger lpsinger merged commit 14f8268 into nasa-gcn:main Oct 16, 2024
12 checks passed
Vidushi-GitHub pushed a commit to Vidushi-GitHub/gcn.nasa.gov that referenced this pull request Nov 6, 2024
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.25.3 to 7.25.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.25.4/packages/babel-preset-env)

---
updated-dependencies:
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Puts test message behind a captcha (nasa-gcn#2547)

Prefer deduplication when installing packages

This decreases the chances of obscure TypeScript errors due to
having multiple versions of the same package in the tree.

Fix broken Circulars hyperlinks by pinning Remix version

Pin Remix version to 2.10.3 to fix broken Circulars cross-reference
hyperlinks.

Fixes nasa-gcn#2563.

Add direct dependency on esbuild

We had an inderect dependency on esbuild because Remix depends on
it, but we should have a direct dev dependency as well because our
own build system calls esbuild itself.

Always send new versions of GCN Circulars over Kafka

See nasa-gcn#2562.

Updates the change request functions to automatically close the corresponding zendesk ticket (nasa-gcn#2546)

Bump lint-staged from 15.2.8 to 15.2.10

Bumps [lint-staged](https://github.com/lint-staged/lint-staged) from 15.2.8 to 15.2.10.
- [Release notes](https://github.com/lint-staged/lint-staged/releases)
- [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md)
- [Commits](lint-staged/lint-staged@v15.2.8...v15.2.10)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Adds option to redistribute email for circulars (nasa-gcn#2569)

Resolves nasa-gcn#2562.

Bump husky from 9.1.4 to 9.1.6

Bumps [husky](https://github.com/typicode/husky) from 9.1.4 to 9.1.6.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v9.1.4...v9.1.6)

---
updated-dependencies:
- dependency-name: husky
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Bump @types/node from 22.5.0 to 22.5.5

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.0 to 22.5.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Bump vite

Bumps  and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). These dependencies needed to be updated together.

Updates `vite` from 5.4.3 to 5.4.6
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite)

Updates `vite` from 4.5.3 to 5.4.6
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: indirect
- dependency-name: vite
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

clarify conditions for when most_probable_direction is present

Bump serve-static and express

Bumps [serve-static](https://github.com/expressjs/serve-static) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `serve-static` from 1.15.0 to 1.16.2
- [Release notes](https://github.com/expressjs/serve-static/releases)
- [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md)
- [Commits](expressjs/serve-static@v1.15.0...v1.16.2)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: serve-static
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Set IceCube notice field names in a code font

Updates the change request form to populate with previously requested changes if they exist (nasa-gcn#2585)

* Updates the change request form to populate with previously requested changes if they exist

* throw all but the 404, types on zendeskticketId

* Apply type narrowing

* Update function to throw error and just return Id

* Update app/lib/zendesk.server.ts

Co-authored-by: Leo Singer <[email protected]>

* Update app/routes/circulars._archive._index/route.tsx

Co-authored-by: Leo Singer <[email protected]>

* Add final check for undefined

* Prettier on zendesk server

---------

Co-authored-by: Leo Singer <[email protected]>

Bump rollup

Bumps  and [rollup](https://github.com/rollup/rollup). These dependencies needed to be updated together.

Updates `rollup` from 4.21.2 to 4.22.4
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.21.2...v4.22.4)

Updates `rollup` from 3.29.4 to 4.22.4
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.21.2...v4.22.4)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
- dependency-name: rollup
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Bump @testing-library/react from 16.0.0 to 16.0.1

Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 16.0.0 to 16.0.1.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v16.0.0...v16.0.1)

---
updated-dependencies:
- dependency-name: "@testing-library/react"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Moves the definition of the send function to resolve issues with kafka related imports in the remix build (nasa-gcn#2590)

Fixes nasa-gcn#2588.

correct typo

Bump typescript from 5.5.4 to 5.6.2

Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.5.4 to 5.6.2.
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.5.4...v5.6.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Bump eslint from 8.56.0 to 8.57.1

Bumps [eslint](https://github.com/eslint/eslint) from 8.56.0 to 8.57.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.56.0...v8.57.1)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

update burstcube status

remove unused import

Bump @types/color-convert from 2.0.1 to 2.0.4

Bumps [@types/color-convert](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/color-convert) from 2.0.1 to 2.0.4.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/color-convert)

---
updated-dependencies:
- dependency-name: "@types/color-convert"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Circulars - Lucene search documentation (nasa-gcn#2502)

Add lvk notice unique ID documentation

Bump @playwright/test from 1.46.1 to 1.48.0

Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.46.1 to 1.48.0.
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.46.1...v1.48.0)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

draft news items

fixed news anchor

adds synonyms moderation front end (nasa-gcn#2538)

Resolves nasa-gcn#2116.

adding synonym moderation link to circulars index page

Adds fermi gbm to json quickstart behind feature flag

Adds other alerts from feedback

Updates schema docs to clarify unevaluatedProperties use

Revise the docs for schema

new producer template

Bump @xmldom/xmldom from 0.8.10 to 0.9.4

Bumps [@xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.8.10 to 0.9.4.
- [Release notes](https://github.com/xmldom/xmldom/releases)
- [Changelog](https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md)
- [Commits](xmldom/xmldom@0.8.10...0.9.4)

---
updated-dependencies:
- dependency-name: "@xmldom/xmldom"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Fix link for EP example alert JSON

SVOM Mission Page

Update app/routes/missions.svom/route.mdx

Co-authored-by: Leo Singer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

synonym moderation UI
4 participants