-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kafka ACL admin to website #2301
base: main
Are you sure you want to change the base?
Conversation
a64936c
to
2f2ca44
Compare
4384405
to
79e8fd5
Compare
I am marking this as ready for review, but I know it will need a semi-hefty refactor after #2268 gets merged in |
5681ba0
to
59e78c2
Compare
Heads up that it is going to take me a while to get to reviewing this. This is going to be a challenging review because it has more security and data consistency impact than typical PRs. |
No worries, I stripped out some of the changes that were starting to touch on the NoticeTypeCheckboxes to a separate branch to try to simplify this one a bit more |
fcb12ea
to
bc8e81f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2301 +/- ##
========================================
- Coverage 6.10% 5.82% -0.28%
========================================
Files 164 166 +2
Lines 4065 4255 +190
Branches 444 460 +16
========================================
Hits 248 248
- Misses 3815 4005 +190
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not entirely content with having buttons to manually synchronize ACLs from the Kafka cluster to DynamoDB records or vice versa.
This will require some more thought about the impacts of changes to ACLS that are made by other means than through the web application --- for example, changes made through the Confluent Control Center.
Yea, I discussed this earlier in the meeting, but this PR needs to be majorly refactored. I'm going to mark it as a draft in the meantime |
Description
New routes and form to create ACLs in DynamoDB and Kafka broker
Sync button to pull ACLs from the broker to DynamoDB