Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dm nondiag test #114

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Added dm nondiag test #114

wants to merge 11 commits into from

Conversation

Jyvol
Copy link

@Jyvol Jyvol commented Jun 15, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #114 (0b93865) into master (629293d) will increase coverage by 2.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   18.24%   21.17%   +2.92%     
==========================================
  Files          27       27              
  Lines        4555     4652      +97     
==========================================
+ Hits          831      985     +154     
+ Misses       3724     3667      -57     
Impacted Files Coverage Δ
enterprise_extensions/sampler.py 21.60% <0.00%> (-0.72%) ⬇️
enterprise_extensions/hypermodel.py 0.00% <0.00%> (ø)
enterprise_extensions/models.py 37.84% <0.00%> (+3.03%) ⬆️
enterprise_extensions/deterministic.py 11.89% <0.00%> (+5.09%) ⬆️
enterprise_extensions/gp_kernels.py 92.79% <0.00%> (+22.52%) ⬆️
enterprise_extensions/blocks.py 62.06% <0.00%> (+25.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629293d...0b93865. Read the comment docs.

Copy link
Member

@paulthebaker paulthebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dm_diag tests look good. The tests passed, but I don't think the dm_nondiag tests are working correctly.

tests/test_models.py Outdated Show resolved Hide resolved
Dmx parameter assert via Pulsar name
tests/test_models.py Outdated Show resolved Hide resolved
tests/test_models.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants