Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feather files #390

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from
Open

Conversation

AaronDJohnson
Copy link
Collaborator

@AaronDJohnson AaronDJohnson commented Aug 4, 2024

Adds the ability to store Pulsar objects and noise dictionaries into FeatherPulsar objects which can be saved and read using pyarrow feather types.

Additionally, this

  • Removes libstempo as a required dependency
  • Removes PINT as a required dependency
  • Removes to_pickle from BasePulsar: pickles should be removed and discouraged for many reasons
  • Adds to_feather to BasePulsar
  • Creates a new FeatherPulsar type which holds data and allows for reading/writing Pulsar objects
  • Removes to_pickle test and adds to_feather test

@AaronDJohnson
Copy link
Collaborator Author

An important design choice is left to be made: FeatherPulsar could potentially be absorbed into BasePulsar. This would require a minimal amount of work, but may make the feather objects a little bigger than they are currently due to storage of _isort and _iisort and other pieces which are not currently stored.

@AaronDJohnson
Copy link
Collaborator Author

Tests are failing because of an installation issue with fastshermanmorrison

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 70.76923% with 19 lines in your changes missing coverage. Please review.

Project coverage is 71.70%. Comparing base (4f6154a) to head (6006e18).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
enterprise/pulsar.py 70.76% 19 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #390       +/-   ##
===========================================
- Coverage   85.33%   71.70%   -13.64%     
===========================================
  Files          13       13               
  Lines        3158     3220       +62     
===========================================
- Hits         2695     2309      -386     
- Misses        463      911      +448     
Files with missing lines Coverage Δ
enterprise/signals/white_signals.py 98.61% <ø> (ø)
enterprise/pulsar.py 28.77% <70.76%> (-65.03%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 508e0d9...6006e18. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant