Move exceptions to new module #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again, I'm not sure this is a good idea, but if we want it it's here. |
dlakaplan
changed the title
dlakaplan
added
needs discussion
awaiting review
abhisrkckl
reviewed
Oct 7, 2024
Comment on lines
+11
to
+24
| class DegeneracyWarning(UserWarning): | ||
| pass | ||
|
|
||
|
|
||
| class ConvergenceFailure(ValueError): | ||
| pass | ||
|
|
||
|
|
||
| class MaxiterReached(ConvergenceFailure): | ||
| pass | ||
|
|
||
|
|
||
| class StepProblem(ConvergenceFailure): | ||
| pass |
There was a problem hiding this comment.
Can you please add docstrings explaining what each of these exceptions mean?
There was a problem hiding this comment.
I don't think I necessarily can, since I didn't write them. I could probably infer some from usage but that would take a while.
|
I think this is a good idea, especially for avoiding circular imports and for improving readability. |
|
Please also add a CHANGELOG entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the custom warnings and exceptions will be in
pint.exceptionsnow. This means that are easier to find/import, and also easier to use (since you can see which are already defined).(the one exception is in
noise_model.py, since some of the exceptions there require access to other functions defined in that module)