Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Corner frequency and fundamental frequency in PLRedNoise and PLDMNoise #1762

Open
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

abhisrkckl
Copy link
Contributor

@abhisrkckl abhisrkckl commented May 10, 2024

See #1366

Fundamental frequency

The TNRedFLow parameter can control the fundamental frequency of the red noise. The relevant expression is

F_1 = 10**TNRedFLow / Tspan

where Tspan is the data span.
This definition is adopted to be consistent with tempo2.

The corresponding parameter for the DM noise is TNDMFLow. I have kept its semantics similar to TNRedFLow although it's not yet implemented in tempo2.

Corner frequency

When corner frequency is specified, the expression for the power spectrum is
image

As fc -> 0, this reduces to
image

The parameter TNRedCorner is defined in tempo2 as

f_c = TNRedCorner / Tspan

@abhisrkckl abhisrkckl linked an issue May 10, 2024 that may be closed by this pull request
@abhisrkckl abhisrkckl changed the title Corner frequency and fundamental frequency in PLRedNoise and PLDMNoise WIP: Corner frequency and fundamental frequency in PLRedNoise and PLDMNoise May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.32%. Comparing base (178002e) to head (bdb12a8).
Report is 209 commits behind head on master.

Current head bdb12a8 differs from pull request most recent head 795d2c5

Please upload reports for the commit 795d2c5 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1762      +/-   ##
==========================================
- Coverage   69.43%   69.32%   -0.11%     
==========================================
  Files         107      106       -1     
  Lines       24925    24895      -30     
  Branches     4430     4432       +2     
==========================================
- Hits        17306    17258      -48     
- Misses       6510     6522      +12     
- Partials     1109     1115       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tempo2-style red noise model
1 participant