Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Improvements to designmatrix and fast random models #1334

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

WIP: Improvements to designmatrix and fast random models #1334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5c880f2
Improvements to designmatrix and fast random models
scottransom Jul 9, 2022
9573efc
Changed PEPOCH_P0 to PEPOCH and added get_spin_terms() method
scottransom Jul 9, 2022
29e7f68
only copy ref model rather than full fitter when making random models
scottransom Jul 10, 2022
2db9de1
Fixed docstring first lines
scottransom Jul 10, 2022
110425f
Specify Residuals load directly
scottransom Jul 10, 2022
145abb3
Replace two asserts with exception raises, if needed
scottransom Jul 10, 2022
58d77f8
Blacked
scottransom Nov 16, 2022
00cf6f2
stylistic code cleanups recommended by Sorcery
scottransom Nov 16, 2022
10bd528
Merge branch 'nanograv:master' into random_models_cleanup
scottransom Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions docs/examples/How_to_build_a_timing_model_component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def __init__(self):
# Add reference epoch time.
self.add_param(
p.MJDParameter(
name="PEPOCH_P0",
name="PEPOCH",
description="Reference epoch for spin-down",
time_scale="tdb",
)
Expand Down Expand Up @@ -188,7 +188,11 @@ def d_F1_d_P1(self):
def get_dt(self, toas, delay):
"""dt from the toas to the reference time."""
# toas.table['tdbld'] stores the tdb time in longdouble.
return (toas.table["tdbld"] - self.PEPOCH_P0.value) * u.day - delay
return (toas.table["tdbld"] - self.PEPOCH.value) * u.day - delay

def get_spin_terms(self):
"""Return a list of the spin term values in the model: [F0, F1, ..., FN]."""
return [self.F0.quantity, self.F1.quantity]

# Defining the phase function, which is added to the self.phase_funcs_component
def spindown_phase_period(self, toas, delay):
Expand Down Expand Up @@ -222,7 +226,7 @@ def d_phase_d_P1(self, toas, param, delay):
DECJ -20:21:29.0 1 0.4
P0 0.016264003404474613 1 0
P1 3.123955D-19 1 0
PEPOCH_P0 53750.000000
PEPOCH 53750.000000
POSEPOCH 53750.000000
DM 223.9 1 0.3
SOLARN0 0.00
Expand Down
Loading