New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Making add PINT builtin parameter from a string #1167

Open

luojing1211 wants to merge 2 commits into nanograv:master from luojing1211:update_parameter_adding

Member

luojing1211 commented Jan 5, 2022 •

edited

Loading

This PR tries to make the add_param() function to be a function for adding PINT built-in parameters. The use cases would be

Add a component. If the parameter's host component is not in the timing model
Add a repeat parameter or indexed parameter to the existing components.
Since add_param()'s function is changed, the old functionality is now called 'inti_param', which initializes a parameter object in the component. init_param() now becomes a lower-level function, is commonly used in the construction of a component and adding repeat or index/prefixed parameters.

luojing1211 added 2 commits

December 9, 2021 23:38


          add timing model parameter to component

7758d40


          change old add_param to init_param, and start the new add_param

95cab6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet