Add local file system functionality to all tools #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSouther
requested changes
Jul 24, 2024
DavidSouther
requested changes
Jul 30, 2024
There was a problem hiding this comment.
Again, I was able to review changes in projects/ and most of simulator/ and components, but please pull out (at least) web/ and related changes to a separate PR.
Looks like there's maybe four changes in here?
- setStatus to Action
- Project test structure
2b. Project files with updated load instructions - Web shell to create files
Sorry I missed your last comment about this. Will do. |
netalondon
force-pushed
the
feat/local-fs
branch
5 times, most recently
from
fd76718
to
7220a12
Compare
Merged
netalondon
force-pushed
the
feat/local-fs
branch
from
1d2dd5c
to
fe7a17c
Compare
2 tasks
DavidSouther
reviewed
Sep 3, 2024
components/src/stores/asm.store.ts
Outdated
Comment on lines
293
to
294
| console.log(path); | ||
| console.log(await fs.scandir("/")); |
simulator/src/test/cputst.ts
Outdated
| this.cpu = new CPU({ ROM: rom }); | ||
| this.reset(); | ||
| } | ||
|
|
||
| override async step() { | ||
| if (!this.hasLoad && !this.fileLoaded) { |
There was a problem hiding this comment.
(opt) De Morgan's for readability?
if (!(this.hasLoaded || this.fileLoaded))
2 tasks
netalondon
force-pushed
the
feat/local-fs
branch
from
c6fbf09
to
d3cc013
Compare
DavidSouther
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #352