-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ScrollController): Replace the hashStore node variable with getter #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter method to handle the undefined case when instantiating ScrollController before the page ready event.
Coverage ReportIlc/serverCommit SHA:5cec4d900b8c80e84257af4d0c995971fb7ae062 Test coverage results 🧪
File details
Ilc/clientCommit SHA:5cec4d900b8c80e84257af4d0c995971fb7ae062 Test coverage results 🧪
File details
RegistryCommit SHA:5cec4d900b8c80e84257af4d0c995971fb7ae062 Test coverage results 🧪
File details
|
blackrabbit99
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the hashStore node variable with a getter method to handle the undefined case when instantiating ScrollController before the page ready event.