fix: improve assets discovery worker stability. #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now does not allow to have parallel update process of the same assets. It ensures timeouts for all the async processes to avoid long or never ending requests to db or HTTPs. It ensures that even if one entity process is failed - others will be successfully updated.
b1ff
requested review from
stas-nc,
alxc,
blackrabbit99,
ALjean and
yehor-manzhula
yehor-manzhula
approved these changes
Aug 15, 2024
|
|
||
| private async iteration() { | ||
| return startBackgroundTransaction(this.tableName, AssetsDiscovery.constructor.name, async () => { | ||
| const now = Math.floor(Date.now() / 1000); |
There was a problem hiding this comment.
I still beleive that enire logic should be changed in order to take in a count
all the previous responses time/timeouts in updatedTime parameter.
Coverage ReportIlc/serverCommit SHA:b9117f1af173eeadb3d10be1f76e049048f2e439 Test coverage results 🧪File details
Ilc/clientCommit SHA:b9117f1af173eeadb3d10be1f76e049048f2e439 Test coverage results 🧪File details
RegistryCommit SHA:b9117f1af173eeadb3d10be1f76e049048f2e439 Test coverage results 🧪File details
|
blackrabbit99
approved these changes
Aug 15, 2024
| () => | ||
| this.iteration().catch((err) => { | ||
| const runLoop = () => { | ||
| this.timerId = setTimeout(async () => { |
There was a problem hiding this comment.
what is the idea behind adding recursion instead of setInterval ?
There was a problem hiding this comment.
setInterval can run processes in paralell, because if process takes more time than interval - interval won't wait completion before next interval is started, that is why it can lead to sum resources for all parallel processes
stas-nc
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now does not allow to have parallel update process of the same assets.
It ensures timeouts for all the async processes to avoid long or never ending requests to db or HTTPs.
It ensures that even if one entity process is failed - others will be successfully updated.