-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ilc/server): don't block the cache if promise never resolves #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas-nc
requested review from
blackrabbit99,
pokhodenko,
b1ff and
yehor-manzhula
April 22, 2024 16:15
b1ff
approved these changes
Apr 22, 2024
stas-nc
force-pushed
the
bugfix/handle-cache-block
branch
from
April 22, 2024 16:56
1f77a84
to
1e7dc5f
Compare
Coverage ReportIlc/serverCommit SHA:eb51f870489126c6dad684f2857807e0b8eed9b8 Test coverage results 🧪
File details
Ilc/clientCommit SHA:eb51f870489126c6dad684f2857807e0b8eed9b8 Test coverage results 🧪
File details
RegistryCommit SHA:eb51f870489126c6dad684f2857807e0b8eed9b8 Test coverage results 🧪
File details
|
yehor-manzhula
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on code analysis and confirmed with unit test there might be a situation when the cache update is stuck and ilc will always return stale cache data.