fix: redirect to 301 instead of 302 in case when only trailing slashe…

…s are present
namecheap · Oct 23, 2024 · b542240 · b542240
1 parent 320723c
commit b542240
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/ilc/server/i18n.js b/ilc/server/i18n.js
@@ -50,6 +50,10 @@ const onRequestFactory =
                 containsOnlySlashes(fixedUrl) &&
                 containsOnlySlashes(req.raw.url);
 
+            if (containsOnlySlashes(req.raw.url) && !shouldSkipRedirectForSlashes) {
+                return reply.redirect(301, '/');
+            }
+
             if (fixedUrl !== req.raw.url && !shouldSkipRedirectForSlashes) {
                 return reply.redirect(fixedUrl);
             }

diff --git a/ilc/server/i18n.spec.js b/ilc/server/i18n.spec.js
@@ -201,6 +201,27 @@ describe('i18n', () => {
                 sinon.assert.calledWithExactly(reply.redirect, '/ua/test');
             });
 
+            it('redirects trailing slash with 301 code', async () => {
+                const detectedI18nConfig = {
+                    locale: 'en-US',
+                    currency: 'USD',
+                };
+
+                i18nParamsDetectionPlugin.detectI18nConfig.onFirstCall().returns(detectedI18nConfig);
+
+                const req = getReqMock('///');
+
+                await onRequest(req, reply);
+
+                const [providedReqRaw, , providedI18nConfig] =
+                    i18nParamsDetectionPlugin.detectI18nConfig.getCalls()[0].args;
+
+                chai.expect(providedReqRaw).to.be.eql(req.raw);
+                chai.expect(providedI18nConfig).to.be.eql(i18nConfig.default);
+
+                sinon.assert.calledWithExactly(reply.redirect, 301, '/');
+            });
+
             it('ua-ua, redirects to URL with correct lang code', async () => {
                 const detectedI18nConfig = {
                     locale: 'ua-ua',