fix(ilc): remove polyfills

namecheap · Aug 9, 2024 · 8d5b75b · 8d5b75b
1 parent 0512dd3
commit 8d5b75b
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 89 deletions.
diff --git a/ilc/package-lock.json b/ilc/package-lock.json
diff --git a/ilc/package.json b/ilc/package.json
@@ -11,12 +11,11 @@
     "test:client": "npm run build:systemjs && cross-env NODE_ENV=test karma start",
     "test:client:watch": "npm run test:client -- --single-run=false --auto-watch=true",
     "start": "node --max-http-header-size 30000 dist/server/index.js",
-    "dev": "npm run build:polyfills && cross-env NODE_ENV=development nodemon -w server -w common -e ts,js,json --exec \"npm run build:server && npm run start | pino-pretty\" ",
-    "build": "rimraf public && npm run build:server && npm run build:systemjs && npm run build:client && npm run build:polyfills",
+    "dev": "cross-env NODE_ENV=development nodemon -w server -w common -e ts,js,json --exec \"npm run build:server && npm run start | pino-pretty\" ",
+    "build": "rimraf public && npm run build:server && npm run build:systemjs && npm run build:client",
     "build:server": "rimraf ./dist && tsc --project ./tsconfig.server.json && copyfiles ./config/* ./server/assets/* ./dist/",
     "build:client": "webpack --config build/webpack.js --progress",
-    "build:systemjs": "node ./systemjs/build.js",
-    "build:polyfills": "mkdir public || true && nwget https://polyfill.io/v3/polyfill.min.js?features=URL%2CObject.entries%2CDocumentFragment.prototype.append%2CElement.prototype.append%2CElement.prototype.remove%2CObject.assign%2CElement.prototype.closest%2CCustomEvent%2CObject.values%2CArray.from -O ./public/polyfill.min.js"
+    "build:systemjs": "node ./systemjs/build.js"
   },
   "author": "",
   "license": "Apache-2.0",
@@ -97,7 +96,6 @@
     "webpack": "^5.88.2",
     "webpack-cli": "^5.1.4",
     "webpack-dev-middleware": "^6.1.1",
-    "wget-improved": "3.3.1",
     "wrapper-webpack-plugin": "^2.2.2"
   },
   "engines": {

diff --git a/ilc/server/tailor/configs-injector.js b/ilc/server/tailor/configs-injector.js
@@ -59,7 +59,6 @@ module.exports = class ConfigsInjector {
             this.#getIlcState(request),
             this.#getSPAConfig(registryConfig),
             `<script>window.ilcApps = [];</script>`,
-            this.#getPolyfill(),
             this.#wrapWithAsyncScriptTag(this.#getClientjsUrl()),
             this.#getNewRelicScript(),
             hrefLangHtml,
@@ -167,30 +166,7 @@ module.exports = class ConfigsInjector {
         };
     };
 
-    #getPolyfill = () => {
-        const url = this.#getPolyfillUrl();
-
-        return (
-            `<script type="text/javascript">` +
-            `if (!(` +
-            `typeof window.URL === 'function' && ` +
-            `Object.entries && ` +
-            `Object.assign && ` +
-            `DocumentFragment.prototype.append && ` +
-            `Element.prototype.append && ` +
-            `Element.prototype.remove` +
-            `)) {` +
-            `document.write('<script src="${url}" type="text/javascript" ${this.#getCrossoriginAttribute(
-                url,
-            )}></scr' + 'ipt>');` +
-            `}` +
-            `</script>`
-        );
-    };
-
     #getClientjsUrl = () => (this.#cdnUrl === null ? '/_ilc/client.js' : urljoin(this.#cdnUrl, '/client.js'));
-    #getPolyfillUrl = () =>
-        this.#cdnUrl === null ? '/_ilc/polyfill.min.js' : urljoin(this.#cdnUrl, '/polyfill.min.js');
 
     #getSPAConfig = (registryConfig) => {
         const apps = _.mapValues(registryConfig.apps, (v) =>

diff --git a/ilc/server/tailor/configs-injector.spec.js b/ilc/server/tailor/configs-injector.spec.js
@@ -283,20 +283,6 @@ describe('configs injector', () => {
                             `<script type="ilc-state">${JSON.stringify(request.ilcState)}</script>` +
                             `<script type="ilc-config">${getSpaConfig()}</script>` +
                             '<script>window.ilcApps = [];</script>' +
-                            `<script type="text/javascript">` +
-                            `if (!(` +
-                            `typeof window.URL === 'function' && ` +
-                            `Object.entries && ` +
-                            `Object.assign && ` +
-                            `DocumentFragment.prototype.append && ` +
-                            `Element.prototype.append && ` +
-                            `Element.prototype.remove` +
-                            `)) {` +
-                            `document.write('<script src="${
-                                cdnUrl + '/polyfill.min.js'
-                            }" type="text/javascript" crossorigin></scr' + 'ipt>');` +
-                            `}` +
-                            `</script>` +
                             `<script src="${
                                 cdnUrl + '/client.js'
                             }" type="text/javascript" crossorigin async></script>` +
@@ -325,7 +311,7 @@ describe('configs injector', () => {
             );
         });
 
-        it('should inject ILC config, omit ILC state, polyfills, client js and new relic <script>, route assets style sheets links into a placeholder when a document has one', () => {
+        it('should inject ILC config, omit ILC state, client js and new relic <script>, route assets style sheets links into a placeholder when a document has one', () => {
             context.run(
                 {
                     request: {
@@ -374,18 +360,6 @@ describe('configs injector', () => {
                             '<!-- TailorX: Ignore during parsing START -->' +
                             `<script type="ilc-config">${getSpaConfig()}</script>` +
                             '<script>window.ilcApps = [];</script>' +
-                            `<script type="text/javascript">` +
-                            `if (!(` +
-                            `typeof window.URL === 'function' && ` +
-                            `Object.entries && ` +
-                            `Object.assign && ` +
-                            `DocumentFragment.prototype.append && ` +
-                            `Element.prototype.append && ` +
-                            `Element.prototype.remove` +
-                            `)) {` +
-                            `document.write('<script src="/_ilc/polyfill.min.js" type="text/javascript" ></scr' + 'ipt>');` +
-                            `}` +
-                            `</script>` +
                             `<script src="/_ilc/client.js" type="text/javascript"  async></script>` +
                             browserTimingHeader +
                             `<link rel="alternate" hreflang="en-us" href="https://test.com/test/route/" data-ilc="1" />` +

diff --git a/install_all.js b/install_all.js
@@ -12,7 +12,7 @@ commands.forEach((cmd) => {
     console.log('');
     console.log(`Installing packages for "${cmd.name}"... Calling: ${cmd.command}`);
     console.log('');
-    const res = spawnSync(cmd.command, { shell: true, timeout: 120000, killSignal: 'SIGKILL', stdio: 'inherit' });
+    const res = spawnSync(cmd.command, { shell: true, killSignal: 'SIGKILL', stdio: 'inherit' });
     if (res.status !== 0) {
         throw new Error(
             `Error during packages installation for "${cmd.name}". Command "${cmd.command}" exited with code "${res.status}".`,