fix: Make peer and blob range queries robust to existence of later key prefixes #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The open range `scan_peer_key..` we were passing into `db.range()` was returning all keys that start with `4u8` *or higher*. Simple fix: give `5u8` as the upper bound of the query. It's worth noting that the same should apply to the blob range queries, I'll try to make a commit for those next.
|
Okay the clippy issue seems unrelated but I guess that's an easy fix as well |
flagged by clippy
Blobs get inserted into sled with `3u8` as their first byte. Peers have a prefix byte of `4u8`. However, the `get_pending_blobs` function uses an open range to query the store, just like `get_peers` used to do. This means we can cause a deserialization error when querying pending blobs, simply by inserting a peer into the store. The open range query will return the peer as a byte string and try to deserialize it into a `Blob` struct.
black-puppydog
changed the title
|
done, added two more commits for the blob range queries. See this run for the failing test. It's fixed in the last commit. :) |
|
Hey @black-puppydog, thanks so much for the PR! Good catch on these open ranges and thanks for including tests. P.s. Great to hear from you! All good over here; enjoying the social media-free life ^_^ Hope you're keeping well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The open range
scan_peer_key..we were passing intodb.range()wasreturning all keys that start with
4u8or higher.Simple fix: give
5u8as the upper bound of the query.It's worth noting that the same should apply to the blob range queries,
I'll try to make a commit for those next.
One commit with a breaking test, one commit to fix it 🙂
P.S. : @mycognosist hope you're doing okay!