Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to optimize the interceptor #3272

Closed
wants to merge 2 commits into from

Conversation

qwjzka
Copy link

@qwjzka qwjzka commented Oct 12, 2024

Pull Request Description

Purpose

This pull request aims to optimize the MyBatis interceptor functionality #1993. The changes include improvements based on performance hints and enhancements to the existing code structure.

Changes Made

Optimized interceptor logic to enhance execution efficiency.
Additional unit tests to validate the changes and ensure the integrity of the functionality.

Note

This pull request is part of my university assignment, Assignment 5 (Group Assignment): PR for Open Source. Sorry for any inconvenience I may have caused, and appreciate your understanding and support!

@harawata
Copy link
Member

Hello @qwjzka ,

This is basically #2001 .
And the added test looks irrelevant.

Closing as a duplicate of #2001

p.s.
For your assignment, I would recommend looking for another, more active project.
This project does not accept many PRs and our review process usually takes very long.

@qwjzka
Copy link
Author

qwjzka commented Oct 12, 2024

Hello @harawata ,

I am really sorry to bother you, but our assignment just ask us to learn how to go through the PR process and the process of setting unit test so I made the things above to get familiar with the process, I am not except for being accepted or merged at all, I am just trying and learning, sorry...

I just hope if you can keep this RP open and I will delete it after our tutor find my processes are correct and give the marks. It will not take too long.... It is ok if my behaviour is not allowed and sorry again for the inconvenience I caused.. sorry...

@harawata harawata reopened this Oct 12, 2024
@qwjzka qwjzka closed this Oct 13, 2024
@qwjzka qwjzka deleted the Try-to-optimize-the-interceptor branch October 15, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants