Junyi-story map #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: templates/storypages/data/title-slide.json modified: templates/storypages/index.html
mjumbewu
reviewed
Nov 10, 2023
There was a problem hiding this comment.
This looks really good for the most part! I left a few comments on the code itself, and if you run the linters you may see a few more issues:
npx eslint templates/storypages/js/
npx stylelint templates/storypages/css/(though most if not all of those issues could be resolved by adding --fix to each of the linter commands).
templates/storypages/index.html
Outdated
| @@ -4,35 +4,96 @@ | |||
| <meta charset="UTF-8"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | |||
|
|
|||
| <title>Story</title> | |||
| <title>Junyi's Selected Work</title> | |||
| <link rel="stylesheet" href="css/normalize.css"> | |||
There was a problem hiding this comment.
suggestion: You should be able to remove this, as there's no normalize.css file in your code.
Suggested change
| <link rel="stylesheet" href="css/normalize.css"> |
templates/storypages/css/index.css
Outdated
Comment on lines
29
to
30
| margin-inline-start: 0px; | ||
| margin-inline-end: 0px; |
There was a problem hiding this comment.
suggestion: Generally in CSS, when something is set to 0, the units are omitted. It's kind of arbitrary, but it's the overwhelming accepted convention.
Suggested change
| margin-inline-start: 0px; | |
| margin-inline-end: 0px; | |
| margin-inline-start: 0; | |
| margin-inline-end: 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.