Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watson wang | historical landmarks of Philadelphia #13

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

watson wang | historical landmarks of Philadelphia #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b3a911b
first commit from watson
watsonvv Oct 2, 2023
821e01a
the dataset is for final project
watsonvv Dec 3, 2023
19d2235
for final project
watsonvv Dec 3, 2023
987d067
Delete philly_city_landmarks.json
watsonvv Dec 4, 2023
6a3f2ba
Delete philly_landmark.json
watsonvv Dec 4, 2023
9274d36
for final project
watsonvv Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9,183 changes: 9,183 additions & 0 deletions philly_landmark.json
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 6 additions & 2 deletions templates/storypages/css/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ main {
overflow-y: auto;

box-shadow: -0.5rem 0 1rem grey;
padding: 1rem;
width: 20rem;
padding: 3rem;
width: 30rem;
}

.slide-content {
Expand Down Expand Up @@ -68,3 +68,7 @@ main {
.slide-nav-select {
min-width: 0;
}

.img-eye{
width: 20px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this image is appearing very small on my browser - I would increase the size. Any easy way to do this would be width: 200px;
however, px are an absolute unit and it would take some back-and-forth resizing/checking to find the perfect px amount. If you want to snap the image to the width of the slide content, just put in a relative unit such as %

Suggested change
width: 20px;
width: 100%;

for more information check out the links in my comment on your html file!

}
16 changes: 16 additions & 0 deletions templates/storypages/data/fifth-slide.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"type": "FeatureCollection",
"features": [
{
"type": "Feature",
"properties": {},
"geometry": {
"coordinates": [
-75.16384737493158,
39.95252023477079
],
"type": "Point"
}
}
]
}
16 changes: 16 additions & 0 deletions templates/storypages/data/fourth-slide.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"type": "FeatureCollection",
"features": [
{
"type": "Feature",
"properties": {},
"geometry": {
"coordinates": [
-75.15040211539755,
39.95573112897412
],
"type": "Point"
}
}
]
}
Loading