[Dialog] Add the aria-modal="true" by default #44118
Merged
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
added
accessibility
Netlify deploy previewhttps://deploy-preview-44118--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
michaldudak
reviewed
Oct 17, 2024
mnajdova
requested review from
michaldudak
and removed request for
michaldudak and
siriwatknp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dialog component is implemented as a modal dialog, but it was missing the aria-modal="true". This PR adds it by default, but also adds the option for people to remove it if for some reason they need to override it. This makes the component compatible with SC 4.1.2