Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Use dedicated indexes for v5 #44100

Draft
wants to merge 2 commits into
base: v5.x
Choose a base branch
from

Conversation

alexfauquette
Copy link
Member

No description provided.

@@ -447,7 +447,7 @@ export default function AppSearch(props) {
initialQuery={initialQuery}
appId="TZGZ85B9TB"
apiKey="8177dfb3e2be72b241ffb8c5abafa899"
indexName="material-ui"
indexName="v5_material-ui"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we need to bump the monorepo and redeploy old mui-x docs to benefit from this? 🤔
That could prove... Difficult. 😆

WDYT about mui-x v5, v6 and v7?
Do I understand correctly, that everything using the old or latest @mui/monorepo will use the latest index and any branch, which merges a monorepo with this indexName will use the index for material-ui v5? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About v5, v6, v7, we can move the dicsussion in mui/mui-x#14855 (comment)

About bumping monorepo, we can create branches mui-x_v5.x_monorepo which is the latest dependency + this commit. And move this Algolia config in some env settings

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, having this index configurable with environment variables sounds way more flexible than relying on a specific monorepo version to be merged. 🙈 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants