Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert files to ES6 #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Convert files to ES6 #12

wants to merge 1 commit into from

Conversation

elchroy
Copy link

@elchroy elchroy commented Oct 7, 2016

Modify library and files to ES6 standard

The following updates were added.

  • Change normal functions to arrow functions.
  • Use template literals for string interpolation
  • Use let for some variables.

@msfeldstein
Copy link
Owner

This looks fine but what is the motivation for moving to ES6? My understanding is it's useful for larger projects, but for simple things like this, the compatibility issues might still be more problems than its worth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elchroy @msfeldstein