Keep newlines in the text formatter #16
Conversation
Replace whitespace manually and keep the text newlines. Also, keep the stories ordering.
|
This is a change of behavior that breaks my personal workflow (and maybe others). I suggest adding a command-line option for this (or at least providing a command-line option to be able to have the old behavior). |
|
Can you share your workflow? |
|
Ok, after checking, it doesn't breaks it, but it looks less good to me. I run with -f markdown and copy-paste the result into our weekly updates tool, as well as save the result locally. I like the format of having "one line per day", but with your patch, I get linebreaks within day entries/items, which is inconsistent with my archive, though the new linebreaks are ignored by the markdown parser, so it's not as bad as I initially thought. My point remains: I think this is a matter of preference, and therefore should be an option, otherwise I would have to do manual edits to the report every week to make it look the way I like. |
|
Well, I think that this was clearly a bug in that newlines entered by the user were omitted. But, if keeping the old behaviour is more important, I guess it could be made so that the user can write 2 newlines to enter a real newline. I guess it's up to Martin :-) |
|
IMHO, having the old behavior under a |
| # Many times people add a lot of duplicate descriptions. Just output one of each. | ||
| all_stories = set(all_stories) | ||
| # Many times people add a lot of duplicate descriptions. Just output | ||
| # one of each, keeping the stories ordering |
There was a problem hiding this comment.
Nit: "keeping the stories ordering" should probably read "keeping the stories in the same order."
There was a problem hiding this comment.
BTW, this seems like a separate change. Do you mind opening up a PR just for this? I'd like to commit it apart from preserving the newlines.
| initial_indent=indent, | ||
| subsequent_indent=indent).strip() | ||
| second_column = os.linesep.join( | ||
| [textwrap.fill(line, |
There was a problem hiding this comment.
I'm not sure I understand what is going on here. Are you wrapping each individual line? Is each line really a paragraph?
|
@hferreiro So I've been thinking about this and I think that since everyone wants a slightly different output, the best approach here would be for PHPReport to use a template language to produce the reports. That way people could have their own custom templates or simply tweak the existing ones. Would that work for you? |
Replace whitespace manually and keep the text newlines. Also, keep the
stories ordering.