Stories #13
Open
Stories #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's shown as (HH:MM story) making it possible to know the duration of each task done in a particular day.
It makes easier to read for days having several tasks.
It helps a lot to find mistakes.
mrobinson
reviewed
Jan 3, 2018
| @@ -340,8 +340,15 @@ class DetailedReport(Report): | |||
| self.formatter.generate_large_text("Onsite hours worked: %s" % DateUtils.format_delta(onsite_time)) | |||
|
|
|||
| def get_stories_for_day_and_user(self, user, date): | |||
| def story_text(task): | |||
There was a problem hiding this comment.
Maybe if the task doesn't have a story it doesn't make sense to add the time either? Also, if there is only one task for the day, isn't adding the story time a little redundant?
|
This is great! I had a couple questions, but it is probably safe to merge this and then just adjust things gradually to make it less awkward with the various ways that people use PHPReport. |
|
I would be interested to have this feature accepted ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are several commits to improve the report when using stories. It adds the duration of every story in the report and adds a new line after every story. It also adds the total hours per story in the aggregate report.