settings: Add uniqueBy function #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
commented
Oct 18, 2022
| @@ -3,7 +3,7 @@ import { Entry, EntryFilterFunction, MicromatchOptions, Pattern, PatternRe } fro | |||
| import * as utils from '../../utils'; | |||
|
|
|||
| export default class EntryFilter { | |||
| public readonly index: Map<string, undefined> = new Map(); | |||
| public readonly index: Map<unknown, undefined> = new Map(); | |||
There was a problem hiding this comment.
I'm also curious if we could have a shared/cached index in case we want to create multiple separate fast-glob instances (such as would be needed to support ordered glob negation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
I've been investigating fast-glob for usage in gulp via glob-stream and I noticed you had a
uniquesetting, but not a way to configure the uniqueness value. We provide auniqueByconfiguration that we passed into aunique-streamto deduplicate values. However, if fast-glob provides that functionality, we can dropunique-streamandpumpifydependencies which would be a huge performance win!What changes did you make? (Give an overview)
I added a
uniqueByoption that is used to pluck the property to use for duplicate entries. This defaults to pluckingentry.pathby default.