Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception when performing listdir on non existing folder #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

desmoteo
Copy link

First of all, thanks for your fork. This code is very useful for projects that are non using pyfilesystem2 from the beginning on s3 and thus struggle to use the original s3fs module.

I noticed that listdir behaves differently as compared to other modules such as osfs, or ufficial S3FS module. Listdir on non existing folders usually raises errors.ResourceNotFound(path), whereas infs-s3fs-ng it just returns an empty list.

I you think this is useful, the proposed PR should make this behavior consistent also in fs-s3fs-ng

Let me know

@desmoteo desmoteo changed the title Raise exception when performing listdir on empty folder Raise exception when performing listdir on non existing folder Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant