fix(cryptofuzz): expose all cryptofuzz tested primitives in lowlevel_* #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constantine is continuously fuzzed on Google OSS-Fuzz through CryptoFuzz.
The test harness is https://github.com/guidovranken/cryptofuzz/blob/042cac0727b99a39dfecfd61d994f5972e2e7e3d/modules/constantine/constantine_harness.nim and has been broken by refactoring preceding the v0.1.0 release:
This PR:
lowlevel_*.nim
files so that it doesn't depend on internal folder structure.^
and~^
It also fails to enable creating a generic version of https://github.com/guidovranken/cryptofuzz/blob/042cac0727b99a39dfecfd61d994f5972e2e7e3d/modules/constantine/constantine_harness.nim#L67-L89
When replacing by a generic:
matchingOrderBigInt(curve)
andcurve.getCurveOrder()
fail to match types.Changing to
curve.getBigInt(kScalarField)
doesn't work either, and changing the internal impl ofgetBigInt
to usetypeof(CurveOrder)
triggers a compiler crash