fix scalarMul_vartime
for tiny multiple 5
#426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another minor issue I encountered playing around with moonmath's BLS6-6. The code previously accidentally only returned 3 for the case 5 using
X.scalarMul_vartime(5)
.I noticed it when comparing manual addition of the generator vs scalar multiplication, in order to construct all elements of the G1 subgroup:
I'd consider adding BLS6-6 as a test curve at a later time. Then I can write a couple of test cases for it (to check all the tiny number code branches) and an example showing some basic curve operations with constantine. Such an example could be quite illustrative. Maybe with some comments of how equivalent operations would look like in SageMath.