Introduce a warning timeout for MQTT topics #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 7, 2024 16:40
The feature allows to define a parameter 'timeout' for each topic. The timeout is specified in seconds. Instead of notifying targets when a message arrives for a topic, mqttwarn will trigger the targets if no message is received on the topic for the specified period of time.
Reduced invasiveness - removed message_to_targets_handler by passing send_to_targets as on_timeout callback - introduced notify_only_on_timeout switch for allowing notifications for arriving messages, too
|
Hi Gerrit, apologies for the late reply. That's a nice liveness sensor you are contributing here. I didn't have a look at the details yet, but if @jpmens or @sumnerboy12 don't have any objections about adding that as a new kind of feature, let's try to bring it into mainline. While your implementation looks pretty solid, I may have a few suggestions about design and implementation details as we go. With kind regards, |
|
@amotl Thank you - and no problem, we're all busy folks ;-) I'd welcome any feedback as I'm not sure if I've done the implementation in the most effective way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature allows to define a parameter 'timeout' for each topic. The timeout is specified in seconds.
Instead of notifying targets when a message arrives for a topic, mqttwarn will trigger the targets if no message is received on the topic for the specified period of time.
That's the first version of this feature, so any feedback is welcome.