-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested patch for a shorthand definition of quoted fields in http_urllib #693
base: main
Are you sure you want to change the base?
Conversation
add list shorthand for params dict + allow optional params in query string
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
==========================================
- Coverage 49.75% 49.60% -0.15%
==========================================
Files 81 81
Lines 4034 4046 +12
==========================================
Hits 2007 2007
- Misses 2027 2039 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Dear Olaf, thanks for your contribution, I like it. While I don't have any objections about merging this improvement, I would like to have @jpmens and @sumnerboy12 the final voice on it. With kind regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it.
I think this can be merged. However, would it be possible to come up with corresponding test cases so the new code and functionality will be covered properly? |
When working with a greater number of transformed fields (e. g. through topic's alldata), the params definition for the target has a lot of redundancy, especially when the field names are crafted to be the parameter names of the query parameters:
This patch provides a shorthand for a definition like
[ #method, #url, { 'param1' : '@param1', ..., 'paramN': '@paramN' }, ...
by allowing lists for the 3rd parameter of the target definition:
[ #method, #url, [ '?param1', ..., '?paramN' ], ...
If a list is provided
[ 'param1', ..., 'paramN' ]
will be interpreted as[ '@param1', ..., '@paramN' ]
?
, fields can be declared optional: they will not be included in the query if the data is invalid or missing from item.data{};[ 'param1', '?param2', ... ]