Tests: Improve full-stack testing without mocking whole modules #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #615 +/- ##
==========================================
- Coverage 37.56% 36.68% -0.89%
==========================================
Files 80 80
Lines 3604 3604
==========================================
- Hits 1354 1322 -32
- Misses 2250 2282 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The `apns` package is not ready for Python3.
amotl
force-pushed
the
amo/tests-no-surrogate
branch
from
984ae69
to
b839aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the test suite used the
surrogatepackage, because it was not ensured that all third-party packages would have been installed within the testing environment.Now, with b4c4619, all third-party packages will always be installed when installing the "test" extra, in order to enable full-stack testing, and improve the overall quality of the test suite.
702fa76 disables testing the
apnsservice plugin, because theapnspackage is not ready for Python3. For upgrading to a successor library, see also #580.