Replace error suppression with initializing the wordData correctly (#11)

mpdf · Jun 4, 2024 · c38b7fb · c38b7fb
1 parent b3c35ac
commit c38b7fb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/QrCode.php b/src/QrCode.php
@@ -440,13 +440,14 @@ private function encode()
 
  $flag = true;
  while ($flag) {
+ $this->wordData[$wordCount] = isset($this->wordData[$wordCount]) ? $this->wordData[$wordCount] : 0;
  if ($remainingBit > $bufferBit) {
- $this->wordData[$wordCount] = ((@$this->wordData[$wordCount] << $bufferBit) | $bufferVal);
+ $this->wordData[$wordCount] = (($this->wordData[$wordCount] << $bufferBit) | $bufferVal);
  $remainingBit -= $bufferBit;
  $flag = false;
  } else {
  $bufferBit -= $remainingBit;
- $this->wordData[$wordCount] = ((@$this->wordData[$wordCount] << $remainingBit) | ($bufferVal >> $bufferBit));
+ $this->wordData[$wordCount] = (($this->wordData[$wordCount] << $remainingBit) | ($bufferVal >> $bufferBit));
  $wordCount++;
 
  if ($bufferBit === 0) {

diff --git a/tests/QrCode/QrCodeTest.php b/tests/QrCode/QrCodeTest.php
@@ -66,4 +66,11 @@ public function testTooLongData()
  new QrCode(base64_encode(random_bytes(1024 * 3)));
  }
 
+ public function testUndefinedIndex()
+ {
+ $value = '1234567890123456.gov.bcb.pix0114028268660001815204000053039865406119.925802BR5912Clip Oba Oba6013Monten Matriz62120508v10173176304F297';
+ $qr = new QrCode($value);
+ $this->assertInstanceOf(QrCode::class, $qr);
+ }
+
 }