Fixed audio size boundary checks #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpariente
reviewed
Dec 28, 2021
Comment on lines
+72
to
+75
| 'frames. At least {} seconds are required, ' | ||
| 'but only {} were found. ' | ||
| 'Returning 1e-5. Please check you wav files' | ||
| .format(((N - 1) * N_FRAME + NFFT) / FS, x.shape[0] / FS), |
There was a problem hiding this comment.
This seems unrelated. It's after removing silent frames, so the minimum audio cannot be known a priori.
There was a problem hiding this comment.
It means "The size after silent frames removal", I though it was implied by the previous sentence in the comment.
| 'found {} and {}'.format(x.shape, y.shape)) | ||
|
|
||
| # Resample is fs_sig is different than fs | ||
| if fs_sig != FS: | ||
| x = utils.resample_oct(x, FS, fs_sig) | ||
| y = utils.resample_oct(y, FS, fs_sig) | ||
|
|
||
| if min(x.shape[0], y.shape[0]) < N_FRAME: | ||
| raise Exception('x and y should at least {} miliseconds long' | ||
| .format(int(1000 * float(N_FRAME) / float(FS)))) |
There was a problem hiding this comment.
Did you take into account the overlap-add in this calculation?
There was a problem hiding this comment.
This is the bound on the input size for the silence removal.
Thinking about it, I think it is actually included in the other check after the removal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.