Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firefox ESR 115 download to /firefox/all/ (Fixes #15083) #15390

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexgibson
Copy link
Member

One-line summary

Adds ESR 115 download button to /firefox/all/

Issue / Bugzilla link

#15083

Testing

http://localhost:8000/en-US/firefox/all/desktop-esr/

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.67%. Comparing base (8ca29f3) to head (0189c06).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
bedrock/firefox/views.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15390      +/-   ##
==========================================
- Coverage   78.68%   78.67%   -0.01%     
==========================================
  Files         156      156              
  Lines        8171     8177       +6     
==========================================
+ Hits         6429     6433       +4     
- Misses       1742     1744       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bedrock/firefox/views.py Outdated Show resolved Hide resolved
@alexgibson
Copy link
Member Author

@robhudson thanks updated

@alexgibson alexgibson added P2 Second level priority - Should have Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Oct 30, 2024
@alexgibson alexgibson marked this pull request as ready for review October 30, 2024 09:27
@stephaniehobson stephaniehobson added the Frontend HTML, CSS, JS... client side stuff label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff Needs Review Awaiting code review P2 Second level priority - Should have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants