Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refresh] Progressively enhance navigation (Fixes #15360) #15381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Oct 24, 2024

One-line summary

This is a bit of a refactor of the navigation CSS to try and help ensure it's accessible even without JS. This helps make our navigation hopefully more resilient in the case of JS breakage / errors in older browsers.

Issue / Bugzilla link

#15360

Testing

  • Nav should function as normal on both desktop and mobile when JS is enabled.
  • When JS is disabled, nav should still work on hover using desktop.
  • When JS is disabled, nav should still be keyboard accessible on desktop.
  • When JS is disabled, nav links should still be displayed on mobile.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (8ca29f3) to head (b64b558).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15381   +/-   ##
=======================================
  Coverage   78.68%   78.68%           
=======================================
  Files         156      156           
  Lines        8171     8171           
=======================================
  Hits         6429     6429           
  Misses       1742     1742           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexgibson alexgibson added P2 Second level priority - Should have Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Oct 25, 2024
@alexgibson alexgibson marked this pull request as ready for review October 25, 2024 08:22
@alexgibson alexgibson changed the title Progressively enhance navigation (Fixes #15360) [Refresh] Progressively enhance navigation (Fixes #15360) Oct 30, 2024
@alexgibson alexgibson added the Refresh 🦖 Work related to the 2024 site refresh label Oct 30, 2024
@stephaniehobson stephaniehobson added the Frontend HTML, CSS, JS... client side stuff label Oct 30, 2024
@stephaniehobson stephaniehobson self-assigned this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff Needs Review Awaiting code review P2 Second level priority - Should have Refresh 🦖 Work related to the 2024 site refresh Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants