Merge #391 #392
Merged
Merge #391 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'pgrep Xvfb' identifies the process by name, which is a more robust test. The output of 'ps aux | grep Xvfb' inside the Docker container running on Apple silicon is slightly different and incompatible with the previous while condition: $ ps aux | grep Xvfb root 3025 0.0 0.4 1451928 32588 pts/0 Sl 14:25 0:00 /rosetta/rosetta /usr/bin/Xvfb Xvfb :99 -screen 0 1024x768x16 root 3142 0.0 0.0 1206448 7808 pts/0 S+ 14:32 0:00 /rosetta/rosetta /usr/bin/grep grep --color=auto Xvfb
Prevent potential infinite loop if Xvfb is not able to start up, for whatever reason.
Exit with exit code 124 ("Command timed out") after 60 seconds.
One-to-one conversion of the previous Travis CI based testing workflow. ❗️ Currently runs on every push ❗️
A separate Github Action will take care of the package deployment to PyPi. Therefore, the pip installation within the Docker container can be removed.
'Run tests' should not run on pushed tags, otherwise we it would get run twice unneccesarily during release tag push.
- Uses PyPA's release Github action.
- The Github repo needs to be set up as a 'Trusted Publisher' on pypi.org.
- ❗️ For testing purposes this workflow currently releases to test.pypi.org ❗️
→ This needs to be removed before a potential merge into main.
Modern twine/build expects long_description to be set. This way 'README.md' will be displayed on https://pypi.org/project/Qt.py/.
This way it will also render correctly on https://pypi.org/project/Qt.py/.
❗️ Currently references 'martin-chatterjee/Qt.py', for testing purposes. ❗️
❗️ Currently states 'version 1.3.9'. This is an assumption, and needs to be changed before merge. ❗️
Test-releases to 'test.pypi.org' as project 'martin-chatterjee-Qt.py'.
Convert CI/CD to GitHub actions.
Remove test.pypi.org for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this transient branch used to test #391