Accounting #159
Open
Accounting #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilspenzel
reviewed
Sep 23, 2024
| ('2024-07-09 11:00:00', '2024-07-09 11:30:00', 1, 3.50, 13.50), | ||
| ('2024-06-07 20:30:00', '2024-06-07 21:30:00', 1, 3.50, 9), | ||
| ('2024-05-05 10:30:00', '2024-05-05 12:00:00', 1, 3.50, 14), | ||
| ('2024-01-01 22:30:00', '2024-01-01 23:00:00', 1, 3.50, 15.50), |
There was a problem hiding this comment.
Die Spalten "fare" und "fare_route" stellen Centbeträge dar -> ganzzahlig
There was a problem hiding this comment.
Ah ok, ich hatte mich schon gewundert, warum in der Datenbank Integer für diese Beträge drin steht.
| { | ||
| for (let row of data.tours) { | ||
| if ( | ||
| row.from.getMonth() == 0 || |
There was a problem hiding this comment.
Das Jahr wird nicht geprüft
There was a problem hiding this comment.
Das stimmt, das habe ich vergessen zu überprüfen.
| if (fare == null || fare_route == null) { | ||
| return 0; | ||
| } | ||
| return (fare_route - fare) * 0.97; |
There was a problem hiding this comment.
0.97 als Konstante mit aussagekräftigem Namen,
Preis kann negativ werden, ist das Absicht?
There was a problem hiding this comment.
Da wir noch nicht wissen, wie genau die Kosten berechnet werden, habe ich das zum Testen so gelöst.
Siehe auch die offenen Fragen im Issue #157.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Siehe Issue #157 für eine Übersicht der abgeschlossenen und noch offenen Aufgaben.