Calculate stop to subshape mapping during import #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds files missing in last commit
Using a `shapes_storage` instance will now always calculate and store shapes and shape offsets.
include/nigiri/loader/gtfs/shape.h
Outdated
| template <typename DoubleRange> | ||
| requires std::ranges::range<DoubleRange> && | ||
| std::is_same_v<std::ranges::range_value_t<DoubleRange>, double> | ||
| inline bool valid_distances(DoubleRange distances) { |
There was a problem hiding this comment.
Suggested change
| inline bool valid_distances(DoubleRange distances) { | |
| bool valid_distances(DoubleRange distances) { |
Templates do not need inline and usually the compiler does a better job at deciding what should be really inlined. So inline is mostly a instruction to the linker, which is not needed in this case (as it's a template).
There was a problem hiding this comment.
Thank you for the reminder.
Due to some changes, the function has been removed entirely.
As values must increase, only leading `0.0`s are allowed.
Assume visual errors will not be noticed by end users. Therefore some optimization can be skipped.
|
Amazing job!! 🤩 🚀 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the shape support, implemented with #127.
Clients may now request the shape of a trip segment. These will be calculated during import, to reduce runtime costs. The corresponding mapping will be stored to a memory map.
As the calculation will take some time, especially for frequent trips using the same stops and shape, results will be cached during import.