Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite login end-points to use unified service #226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pythys
Copy link

@pythys pythys commented Jan 8, 2024

this depends on first approving this PR on the moqui framework

@jonesde
Copy link
Member

jonesde commented Jan 10, 2024

From a read through the code changes there are changes to the functionality so I am not confident in merging this until some testing is done of the various flows involved in login with and without a second factor required, and with correct and incorrect password and MFA code.

If someone else would like to help with this, please list the test scenarios you run and the results. I'll get to this sooner or later but am ill right now, and I see this as a lower priority as it is a code de-dup/cleanup effort more than a needed functional change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants