This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
Fix \d not working in version-pattern
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `unicode-perl` feature was disabled for the regex dep at some point, but we rely on this for our usage example.
This will keep breaking for every moon release until development on v1 stops.
Phault
commented
Feb 17, 2024
| @@ -7,7 +7,6 @@ generate_resolve_versions_tests!( | |||
| "1.0.3" => "1.0.3", | |||
| "1.4" => "1.4.0", | |||
| "1.5" => "1.5.1", | |||
| "1" => "1.19.3", | |||
There was a problem hiding this comment.
I removed this, as the test breaks every time moon is updated.
|
@Phault I removed a lot of the regex features back in the day because it made the file size really large. Let me do some testing and verify things. |
|
Only added about 30kb, which isn't too bad. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example for the
version-patternin the docs does not actually work, as it uses the\dcharacter class, which is currently disabled for the regex dep. This PR enables support for it (as well as\wand\s).I understand that the plugin should be kept very lightweight, so alternatively the example could just be updated to use
[0-9]ranges instead of\dand we can just close this PR. I suspect most people would expect\dto work though.