Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quarantine filter in customer grid #37

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Add quarantine filter in customer grid #37

merged 1 commit into from
Apr 2, 2024

Conversation

delyriand
Copy link
Member

@delyriand delyriand commented Mar 29, 2024 •
edited
Loading

image

FYI, CI is fixed in #39

@madamebiz madamebiz added the Status: needs review Needs review label Mar 29, 2024
lanfisis
lanfisis approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@lanfisis lanfisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just run test.phpcs.fix but ok for the code

@delyriand delyriand force-pushed the feature/add-quarantine-filter branch from 79aee5f to dc4c3b3 Compare April 2, 2024 07:45
@maximehuran
Copy link
Member

You need to upgrade the node version from 14 to 16 in CI

@delyriand delyriand force-pushed the feature/add-quarantine-filter branch from dc4c3b3 to 65b5c6e Compare April 2, 2024 08:06
@delyriand delyriand merged commit 8ee3962 into monsieurbiz:master Apr 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximehuran maximehuran maximehuran approved these changes

@lanfisis lanfisis lanfisis approved these changes

@Kiwikoti Kiwikoti Awaiting requested review from Kiwikoti

Assignees
No one assigned
Labels
Status: needs review Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@delyriand @maximehuran @lanfisis @madamebiz