Targets improvements #175
Merged
Targets improvements #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using CPS project system, fixes transform on save and displays relevant item metadata in VS property window.
Output items for templates and preprocessed templates now have InputFIle and Dependencies metadata.
Apparently when we tried to pack a TFM-specific file called _._ into buildTransitive to indicate that there were no targets for that TFM, NuGet arbitrarily decided to pack the targets file from a different TFM instead ¯\_(ツ)_/¯ Borrow the logic from https://github.com/dotnet/runtime/blob/bb74bb79db53eae474977a0928756a0db7fc6a3f/src/libraries/Microsoft.Extensions.Configuration.Binder/src/buildTransitive/Microsoft.Extensions.Configuration.Binder.targets#L17 as it's easier than overriding NuGet's weird pack behavior. Fixes #174
When relative pragmas are enabled, and includes already have relative path, and there is no base bath from which to calculate relative paths, use the existing relative path as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.